[PATCH] D19037: [llvm-c] Add the ability to create debug locations

Jeroen Ketema via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 14:40:13 PDT 2016


jketema added inline comments.

================
Comment at: include/llvm-c/Core.h:2790
@@ -2789,1 +2789,3 @@
 /* Metadata */
+LLVMValueRef LLVMCreateDebugLocation(LLVMContextRef C, unsigned Line,
+                                     unsigned Col, const LLVMValueRef Scope,
----------------
AlexDenisov wrote:
> Would not it be better to name it `LLVMCreateDILocation`? 
> This way other methods from the DI family can be imported consistently.
> Just a side note though :)
I was trying to match the set and get functions below.


http://reviews.llvm.org/D19037





More information about the llvm-commits mailing list