[PATCH] D18706: [DWARF] Force a linkage_name on an inlined subprogram's abstract origin

[David Blaikie via llvm-commits]

dblaikie added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:667-668
@@ -666,4 +666,4 @@
 
-void DwarfUnit::addLinkageName(DIE &Die, StringRef LinkageName) {
-  if (!LinkageName.empty() && DD->useLinkageNames())
+void DwarfUnit::addLinkageName(DIE &Die, StringRef LinkageName, bool Abstract) {
+  if (!LinkageName.empty() && DD->useLinkageName(Abstract))
     addString(Die,
----------------
Actually, one thing - could you pull the useLinkageName/abstract part out into the caller, perhaps?

What I'm thinking is that if it's sufficiently re-structured, the AbstractSPDies lookup shouldn't be necessary except when this option is enabled.


http://reviews.llvm.org/D18706