[llvm] r265815 - [Object] Report an error if .alt_entry is used with ELF or COFF.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 13:09:45 PDT 2016


On 11 April 2016 at 15:44, Lang Hames <lhames at gmail.com> wrote:
> Hi Rafael,
>
> Yep - this was just a temporary hack. It's been fixed as of r265975.
>
> Regarding test cases - what's the bar for something like this. I'd have
> included a test that the directive was handled correctly on the platforms
> it's intended for, but testing every (unsupported) directive on every
> platform seems like overkill.

It is fuzzy. One of my rules is "we got this wrong before", which is
why I think it would be nice to have a test even if it is just
printing "unknown directive".

Cheers,
Rafael


More information about the llvm-commits mailing list