[PATCH] D19011: [ELF] - Change -t implementation to print which archive members are used.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 11:05:48 PDT 2016


grimar added inline comments.

================
Comment at: ELF/SymbolTable.cpp:100-107
@@ -87,10 +99,10 @@
 
   // Lazy object file
   if (auto *F = dyn_cast<LazyObjectFile>(FileP)) {
     LazyObjectFiles.emplace_back(cast<LazyObjectFile>(File.release()));
     F->parse();
     for (Lazy &Sym : F->getLazySymbols())
       addLazy(&Sym);
     return;
   }
 
----------------
ruiu wrote:
> You want to move this code before `if (Config->Trace)`.
Right. Added testcase for that.

Not relative to this patch - I didn't find any testcase that checks --end-lib

================
Comment at: test/ELF/Inputs/trace-ar1.s:1
@@ +1,2 @@
+.globl _used;
+_used:
----------------
ruiu wrote:
> Remove ;
Done.

================
Comment at: test/ELF/Inputs/trace-ar2.s:1
@@ +1,2 @@
+.globl _notused;
+_notused:
----------------
ruiu wrote:
> Remove ;
Done.


http://reviews.llvm.org/D19011





More information about the llvm-commits mailing list