[PATCH] D19053: [LNT] Some more docs for the LNT json file format.

[Chris Matthews via llvm-commits]

cmatthews accepted this revision.
cmatthews added a comment.
This revision is now accepted and ready to land.

Kristof, thank you for writing this! We need to do this kind of stuff more for LNT!  I have sent people raw json files and said "make it like that" way too many times!!


================
Comment at: docs/concepts.rst:63-65
@@ -62,5 +62,5 @@
 
 Any program can submit results data to LNT, and specify any test suite.  The
 data format is a simple JSON file, and that file needs to be HTTP POSTed to the
 submitRun URL.
 
----------------
jgreenhalgh wrote:
> Or use the lnt import command line tool.
An example with curl would be handy.

================
Comment at: docs/importing_data.rst:29
@@ +28,3 @@
+          "run_order": "265649",
+          "tag": "nts"
+        }
----------------
jgreenhalgh wrote:
> You could mention that arbitrary String->String fields can be added here, and will be displayed in the Run Info in the interface.
This should be emphasized, we use lots of extra fields and they are very handy.

Since the the data is parsed duing the render, you can use it in the templates, so it is essentially a 1 line change to render extra run and machine data.  We locally customize LNT like this all the time.

================
Comment at: docs/importing_data.rst:52
@@ +51,3 @@
+              "Info": {},
+              "Name": "nts.suite1/program1.exec"
+          }
----------------
jgreenhalgh wrote:
> What is the difference between adding a seperate test with the same name, and adding multiple data items to "Data"?
I have never tested that, but I have a feeling it would not matter, either way a series of samples would be created linking back to the benchmark name.


http://reviews.llvm.org/D19053