[PATCH] D18494: ThinLTO: add module caching handling.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 09:15:20 PDT 2016


tejohnson added a comment.

Is this essentially done and ready for re-review? (Realize it is dependent on outstanding patch http://reviews.llvm.org/D18987.)


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:408
@@ -312,2 +407,3 @@
+    std::map<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR,
     ThinLTOCodeGenerator::CachingOptions CacheOptions, bool DisableCodeGen,
     StringRef SaveTempsDir, unsigned count) {
----------------
Not directly related to this patch, but I just noticed that the CacheOptions parameter here is unused.


http://reviews.llvm.org/D18494





More information about the llvm-commits mailing list