[PATCH] D17584: Cleanup inline cost analysis code

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 08:59:45 PDT 2016


ahatanak added a comment.

In http://reviews.llvm.org/D17584#395995, @eraman wrote:

> Checkd in this part. This actually fixes the issue Akira had because you won't end up with a positive bonus, but an initial zero threshold. But the complex control flow means there could be other unintended results.


Thanks! r265852 fixed the code size regression for the user's project.

Why wasn't the test case (inline_unreachable-2.ll) checked in? The test passes only after the fix in r265852 is applied, so it seems that it could have been checked in too?


http://reviews.llvm.org/D17584





More information about the llvm-commits mailing list