[PATCH] D18999: [ELF/LTO] Parallel Codegen for LLD

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 08:34:05 PDT 2016


On Wed, Apr 13, 2016 at 4:59 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 12 April 2016 at 22:42, Davide Italiano <dccitaliano at gmail.com> wrote:
>> davide added a comment.
>>
>> I agree I expected a bigger speedup. I'll investigate further (and post more precise numbers) ASAP.
>>
>>
>> ================
>> Comment at: ELF/LTO.cpp:142
>> @@ -138,1 +141,3 @@
>>
>> +static SubtargetFeatures getFeatures(Triple &TheTriple) {
>> +  SubtargetFeatures Features;
>> ----------------
>> rafael wrote:
>>> Is this related to parallel LTO?
>> you use the returned type as argument to codeine.
>
> And that is eventually passed to create a target machine. We currently
> use just "".
>
> This highlights a problem in the API: we create a TargetMachine in two
> places. Could a TargetMachine be passed to splitCodegen?
>

I think so. I'll try to make the change later today.


More information about the llvm-commits mailing list