[PATCH] D19012: [Clang][Avx512][BuiltIn] Adding brodcast builtin to clang

Igor Breger via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 02:01:09 PDT 2016


igorb added inline comments.

================
Comment at: lib/Headers/avx512dqintrin.h:788
@@ +787,3 @@
+  return (__m512) __builtin_ia32_broadcastf32x2_512_mask ((__v4sf) __A,
+                (__v16sf)
+                __O, __M);
----------------
could you please put casting on the same line with argument

================
Comment at: lib/Headers/avx512dqintrin.h:827
@@ +826,3 @@
+{
+  return (__m512d) __builtin_ia32_broadcastf64x2_512_mask ((__v2df)
+                 __A,
----------------
could you please put casting on the same line with argument ( the same regarding the code below)

================
Comment at: lib/Headers/avx512dqintrin.h:865
@@ +864,3 @@
+                 __A,
+                 (__v16si)
+                 __O, __M);
----------------
could you please put casting on the same line with argument

================
Comment at: lib/Headers/avx512dqintrin.h:901
@@ +900,3 @@
+                 __A,
+                 (__v16si)
+                 _mm512_setzero_si512 (),
----------------
could you please put casting on the same line with argument

================
Comment at: lib/Headers/avx512vldqintrin.h:978
@@ +977,3 @@
+{
+  return (__m256d) __builtin_ia32_broadcastf64x2_256_mask ((__v2df)
+                 __A,
----------------
could you please put casting on the same line with argument ( the same regarding the code below)


http://reviews.llvm.org/D19012





More information about the llvm-commits mailing list