[PATCH] D18711: Change how we apply rellocations

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 16:35:08 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

The current way of handling relocation is too overloaded and hard to (or even impossible to) understand. This patch is toward the right direction.

We eventually want to have a separate function to apply relocations for non-alloc sections becasue non-alloc sections don't need these crazy number of decisions we make in scanRelocs. I believe that writing a separate function for non-alloc to directly apply relocations is fairly easy. So I consider the performance degradation caused by this change is rather temporary.


http://reviews.llvm.org/D18711





More information about the llvm-commits mailing list