[PATCH] D18340: AMDGPU: allow specifying a workgroup size that needs to fit in a compute unit

Bas Nieuwenhuizen via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 16:28:11 PDT 2016


bnieuwenhuizen added inline comments.

================
Comment at: lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:125
@@ +124,3 @@
+
+  if (AMDGPU::isCompute(F->getCallingConv()))
+    MaximumWorkGroupSize = AMDGPU::getMaximumWorkGroupSize(*F);
----------------
arsenm wrote:
> Why is this function needed? You can just compare to F->getCallingConv directly
I want to have everything in the compute stage here.  Note that we have multiple calling conventions for that: at least one for compute kernels and one for mesa shaders.

This is a helper to check if it is one of the compute stage calling conventions, so we only have one place we need to remember to put all the conventions.


http://reviews.llvm.org/D18340





More information about the llvm-commits mailing list