[PATCH] D19033: ELF: Use hidden visibility for all DefinedSynthetic symbols.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 14:23:07 PDT 2016


pcc created this revision.
pcc added reviewers: atanasyan, rafael, ruiu.
pcc added a subscriber: llvm-commits.

This simplifies the code by allowing us to remove the visibility argument
to functions that create synthetic symbols.

The only functional change is that the visibility of the MIPS "_gp" symbol
is now hidden. Because this symbol is defined in every executable or DSO, it
would be difficult to observe a visibility change here, so this seems safe,
but I'd like a MIPS expert to take a look.

http://reviews.llvm.org/D19033

Files:
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h
  ELF/Symbols.cpp
  ELF/Symbols.h
  ELF/Writer.cpp
  test/ELF/basic-mips.s
  test/ELF/mips-dynamic.s
  test/ELF/mips-got-relocs.s
  test/ELF/mips-gp-disp.s
  test/ELF/mips-gp-local.s
  test/ELF/mips-gprel32-relocs-gp0.test
  test/ELF/mips-gprel32-relocs.s
  test/ELF/mips-hilo-gp-disp.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19033.53462.patch
Type: text/x-patch
Size: 12850 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160412/ae0e8d5f/attachment.bin>


More information about the llvm-commits mailing list