[PATCH] D18883: Add a pass to name anonymous/nameless function

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 14:04:18 PDT 2016


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D18883#395368, @tejohnson wrote:

> Perhaps this should be named something more general than NameAnonFunctionPass. This is the naming scheme pcc was proposing for promoted values as well, and eventually it would be good to do any early renaming/promotion of locals here. The moduleHash() facility could also be used during importing to rename/promote imported locals (i.e. invoked from FunctionImportGlobalProcessing), for anything not promoted/renamed during the compile step, so it would also be good to put that into a more general location.


I had the above comment. However, I don't have strong objections to putting this in as-is. It could be refactored or renamed later to use the same naming facility for early promotion/renaming.


http://reviews.llvm.org/D18883





More information about the llvm-commits mailing list