[PATCH] Fix a couple of use-after-frees in X86ISelDAGToDAG

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 11:14:53 PDT 2016


While looking at llvm.org/PR26808 I found a couple of use-after-frees in
X86ISelDAGToDAG, where we RAUW a node and then try to keep using it. The
attached patch fixes the tests that crash under ASan, but it feels a bit
targetted and kludgy. I'm afraid a robust fix would involve a lot of
refactoring of how X86ISelDAGToDAG works though, and I certainly won't
be able to do that any time soon.

Thoughts?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86-dag-to-dag.patch
Type: text/x-patch
Size: 2324 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160412/3a3261d7/attachment.bin>


More information about the llvm-commits mailing list