[PATCH] D19012: [Clang][Avx512][BuiltIn] Adding brodcast builtin to clang

Igor Breger via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 06:00:58 PDT 2016


igorb added inline comments.

================
Comment at: include/clang/Basic/BuiltinsX86.def:1981
@@ +1980,3 @@
+TARGET_BUILTIN(__builtin_ia32_broadcastss256_mask, "V8fV4fV8fUc","","")
+TARGET_BUILTIN(__builtin_ia32_pbroadcastw512_mask, "V32sV8sV32sUi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_pbroadcastb128_mask, "V16cV16cV16cUs","","avx512f")
----------------
it should be "avx512bw" ?

================
Comment at: lib/Headers/avx512bwintrin.h:2065
@@ +2064,3 @@
+                   (__v64qi)_mm512_setzero_si512(),
+                   (__mmask64) -
+                   1);
----------------
could you please put casting on the same line with argument


http://reviews.llvm.org/D19012





More information about the llvm-commits mailing list