[PATCH] D18890: [AArch64] add SSA Load Store optimization pass

[Renato Golin via llvm-commits]

rengolin added a comment.

I'm happy with the changes, with formatting fixes pointed by @mcrosier. I'll leave the approval to @junbuml, though.


================
Comment at: lib/Target/AArch64/AArch64SSALoadStoreOptimizer.cpp:72
@@ +71,3 @@
+                        MachineInstr &MI) {
+  for (MachineBasicBlock::iterator MBBI = MBB.begin(), E = MBB.end(); MBBI != E;
+       ++MBBI) {
----------------
Do'h, ignore me.

================
Comment at: lib/Target/AArch64/AArch64SSALoadStoreOptimizer.cpp:169
@@ +168,3 @@
+
+  return false;
+}
----------------
Right.

================
Comment at: lib/Target/AArch64/AArch64SSALoadStoreOptimizer.cpp:381
@@ +380,3 @@
+    unsigned MIReg = getLdStRegOp(MI).getReg();
+
+    // Check if there exists a def instruction for the register operand of MI.
----------------
clang-format is a tool that you pass on the source that formats it as a given standard. The default standard is LLVM's, so that new code always adhere to the standard without much effort.

================
Comment at: test/CodeGen/AArch64/ssa-ldst-opt.ll:2
@@ +1,3 @@
+; RUN: llc -march=aarch64 -verify-machineinstrs -asm-verbose=false -aarch64-ssa-load-store-opt -o - %s | FileCheck %s
+
+; This test is for 'AArch64 load/store optimization in SSA form'.
----------------
Thanks!


http://reviews.llvm.org/D18890