[PATCH] D18366: Factor PrologEpilogInserter around spilling, frame finalization, and scavenging

[Derek Schuff via llvm-commits]

dschuff added inline comments.

================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:211
@@ +210,3 @@
+           "Virtual-register targets do not support register scavenging");
+  } else {
+    // If register scavenging is needed, as we've enabled doing it as a
----------------
qcolombet wrote:
> I still don’t like this part of the patch.
> We could do another helper function here, couldn’t we?
Yes, sorry if I wasn't clear enough in my comment from 3/29; the intent was to get your opinion on the general direction using CSR spilling and then apply the same idea to scavenging. Since you didn't have any objection to the rest of it, I'll go ahead and do that now :)


http://reviews.llvm.org/D18366