[PATCH] D18994: [LTO] Switch Module to std::unique_ptr<>

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 15:45:40 PDT 2016


On Mon, Apr 11, 2016 at 3:39 PM, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> ruiu added inline comments.
>
> ================
> Comment at: ELF/LTO.h:43
> @@ +42,3 @@
> +  BitcodeCompiler()
> +      : Combined(new llvm::Module("ld-temp.o", Context)), Mover(*Combined){};
> +
> ----------------
> ruiu wrote:
>> Need a space before {}. (Or run clang-format-diff.)
> Maybe it's because you have an extra ; at end of the line?
>
Yes, that was it. Submitted.

>
> http://reviews.llvm.org/D18994
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list