[PATCH] D18711: Change how we apply rellocations

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 15:04:37 PDT 2016

> ================
> Comment at: ELF/InputSection.h:53
> @@ +52,3 @@
> +    R_TLSLD_PC
> +  } Expr;
> +  uint32_t Type;
> ----------------
> I'd probably avoid naming this "Expr" because it is not an expression. It is more like the relocation type, right?

It is part of it. The relocation type also says where to write (bits
10-21 for example), which is why I went with expr: it mostly just
shows which expression the relocation computes.

I will upload a new WIP patch in a second.

The final version I want to commit has far fewer enums by representing
the target by just addend and output section. With that representation
we don't need, for example, R_PC and and R_GOT_PC.


More information about the llvm-commits mailing list