[PATCH] D18796: Correct IDF calculator for ReverseIDF

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 14:39:21 PDT 2016


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Daniel,

Looks reasonable to me.
Maybe a typedef to add a bit of syntactic sugar.

Cheers,
-Quentin


================
Comment at: lib/Analysis/IteratedDominanceFrontier.cpp:103
@@ +102,3 @@
+template class IDFCalculator<BasicBlock *>;
+template class IDFCalculator<Inverse<BasicBlock *>>;
+}
----------------
Perhaps typedef those so that clients explicitly use forward or reverse IDF? 


http://reviews.llvm.org/D18796





More information about the llvm-commits mailing list