[PATCH] D18935: Fix live interval update of Dead PHI for r265547

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Wei,

LGTM modulo maybe a rephrase of the comment on the test cases.

Cheers,
-Quention


================
Comment at: test/CodeGen/ARM/interval-update-remat.ll:2
@@ +1,3 @@
+; RUN: llc -verify-regalloc < %s
+; PR27275: After enable remat for vreg defined by PHI VNI, live range update
+; after split don't know how to remove Dead PHI VNI and related Dead segment,
----------------
What about:
When enabling remat for vreg defined by PHIs, make sure the update of the live range removes dead phi. Otherwise, we may end up with PHIs with incorrect operands and that will trigger assertions or verifier failures in later passes.

================
Comment at: test/CodeGen/X86/interval-update-remat.ll:156
@@ +155,3 @@
+  tail call void (i8*, ...) @printf(i8* getelementptr inbounds ([12 x i8], [12 x i8]* @.str, i32 0, i32 0), i64 %conv39)
+  %16 = load i64, i64* @g, align 8
+  %neg49 = xor i64 %16, 4294967295
----------------
Run opt -instnamer to get rid of the %[0-9]+ variables.


Repository:
  rL LLVM

http://reviews.llvm.org/D18935