[PATCH] D18471: [CodeGen] Don't assume that fixed stack objects are aligned in a stack-realigned function.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 11:05:49 PDT 2016


rnk added inline comments.

================
Comment at: lib/CodeGen/MachineFunction.cpp:87-88
@@ -80,2 +86,4 @@
+      MachineFrameInfo(getFnStackAlignment(STI, Fn),
                        STI->getFrameLowering()->isStackRealignable(),
-                       !F->hasFnAttribute("no-realign-stack"));
+                       !F->hasFnAttribute("no-realign-stack"),
+                       !F->hasFnAttribute("no-realign-stack") &&
----------------
cdavis5x wrote:
> rnk wrote:
> > As a separate issue, I noticed that StackRealignable and RealignOpt are redundant. We can get by with just StackRealignable, and making that be `STI->getFrameLowering()->isStackRealignable() && F->hasFnAttribute("no-realign-stack")`.
> Yeah, but I think I'll save that for another patch.
I went ahead and did this in  r265971, it was more of an idle thought while staring at the related code. Thanks!


Repository:
  rL LLVM

http://reviews.llvm.org/D18471





More information about the llvm-commits mailing list