[PATCH] D18909: Cleanup Store Merging in UseAA case

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 07:09:47 PDT 2016


niravd added a comment.

In http://reviews.llvm.org/D18909#396963, @jyknight wrote:

> > Not one that highlights the difference. This is a factoring of some of the factorable cleanup of http://reviews.llvm.org/D14834. http://reviews.llvm.org/D14834 will remove the old path for store merging.
>
>
> You ought to be able to detect that the chain is being set correctly now and wasn't before -- at the very least by looking at the nodes being produced.
>
> Does this change by itself fix the test case in http://reviews.llvm.org/D17836?


Ah. So this isn't just a clean up, but actually fixing the UseAA case of merging. You're intuition is right here James, the test from http://reviews.llvm.org/D17836 case does work. I'll update the diff.


http://reviews.llvm.org/D18909





More information about the llvm-commits mailing list