[PATCH] D18477: Drop debug info for DISubprograms that are not referenced by anything

[David Blaikie via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks - I assume a bunch of this will get simpler once you actually reverse the subprogram<>compile unit mapping? (like the extra check added at DwarfDebug.cpp:530)

Also, do you have any numbers of debug info size changes? I imagine this reduces DWARF size perhaps noticeably for linkonce functions?


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:531-533
@@ -553,1 +530,5 @@
+    if (ProcessedSPNodes.count(P.first))
+      forBothCUs(*P.second, [&](DwarfCompileUnit &CU) {
+          CU.finishSubprogramDefinition(cast<DISubprogram>(P.first));
+        });
 }
----------------
Did some formatting get changed here? ^ (Phab shows no diff highlight, but that the forBothCUs doesn't line up with the closing '});'


http://reviews.llvm.org/D18477