[PATCH] D17736: [SSP] Remove llvm.stackprotectorcheck.

[Tim Shen via llvm-commits]

timshen added a comment.

Thanks for the style check! It's a big patch and I clearly missed those.

Also rebased to include http://reviews.llvm.org/D18632's change.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:1361
@@ -1357,1 +1360,3 @@
     }
+    auto &SP = getAnalysis<StackProtector>();
+    if (dyn_cast<ReturnInst>(LLVMBB->getTerminator()) && SP.hasPrologue() &&
----------------
echristo wrote:
> Comment.
As suggested by gottesmm, moved this condition into StackProtector::shouldEmitSDCheck(), and documented.


http://reviews.llvm.org/D17736