[PATCH] D18901: ARM: Use a callee save register for the swiftself parameter.
Quentin Colombet via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 8 11:38:47 PDT 2016
qcolombet added inline comments.
================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:914
@@ -925,1 +913,3 @@
+ bool isLiveIn = MF.getRegInfo().isLiveIn(Reg);
+ if (!isLiveIn)
MBB.addLiveIn(Reg);
----------------
Because if the register is live we *must not* add it into the live-in.
================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:925
@@ -934,1 +924,3 @@
+ // passed in callee saved registers.
+ Regs.push_back(std::make_pair(Reg, /*isKill=*/!isLiveIn));
}
----------------
Same comment as x86: conservatively correct.
Repository:
rL LLVM
http://reviews.llvm.org/D18901
More information about the llvm-commits
mailing list