[PATCH] D18784: [PGO] Remove redundant VP runtime calls

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

I think it is better here (see inlined nit), now you need test to show what exactly it does / doesn't do (I don't know much about this call).


================
Comment at: lib/Transforms/Scalar/ADCE.cpp:65
@@ -63,1 +64,3 @@
 
+static bool instrumentsConstants(Instruction &I) {
+  if (CallInst *CI = dyn_cast<CallInst>(&I))
----------------
nit: use a verb `isInstrumentsConstant`, and add a one-line comment above the function.

================
Comment at: lib/Transforms/Scalar/ADCE.cpp:82
@@ -71,1 +81,3 @@
+      if (instrumentsConstants(I))
+        continue;
       Alive.insert(&I);
----------------
Comment.


http://reviews.llvm.org/D18784