[PATCH] D18901: ARM: Use a callee save register for the swiftself parameter.

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 11:15:38 PDT 2016


t.p.northover added inline comments.

================
Comment at: test/CodeGen/ARM/swiftself.ll:2
@@ -3,1 +1,3 @@
+; RUN: llc -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck --check-prefix=CHECK --check-prefix=OPT %s
+; RUN: llc -O0 -verify-machineinstrs -mtriple=armv7k-apple-ios8.0 -mcpu=cortex-a7 -o - %s | FileCheck %s
 
----------------
t.p.northover wrote:
> Why? All labels are under CHECK; it's a fairly common FileCheck idiom to have a shared check-prefix and a run-specific one to save duplication.
> 
> But I think there actually is an issue here: OPT != CHECK-OPT.
Sorry, I was looking at a newer diff. You were right about the original. I think OPT is still problematic though.


Repository:
  rL LLVM

http://reviews.llvm.org/D18901





More information about the llvm-commits mailing list