[PATCH] D18878: [Polly] Allow overflow of indices with constant dimensions size

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 8 06:41:28 PDT 2016


Meinersbur added inline comments.

================
Comment at: test/ScopInfo/multidim_fixedsize_multi_offset.ll:12
@@ -11,3 +23,3 @@
 ;        B[i][0]++;
 ;        C[i][0]++;
 ;      }
----------------
Meinersbur wrote:
> The scop was only rejected because the computed MemoryAccess was
> ```
> { [i0] -> MemRef_A[0, 2 + 2i0] }
> ```
> which is unconditionally out of bounds.
Just to add that this is not wrong; The out of bounds conditions are added to the RTCs. That is, even if the computed linear are not completely out of bounds, only the executions where it is within the last dimension' bounds run the optimized version.

That is, r265379 is not only a 'partial fix', but a complete one; This patch only extents the context so more executions can run the optimized version.


http://reviews.llvm.org/D18878





More information about the llvm-commits mailing list