[PATCH] D18757: [Coverage] Update testing methods to support more than two files.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 12:51:54 PDT 2016


vsk added a comment.

Thanks, lgtm with the one nit.


================
Comment at: llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp:209
@@ +208,3 @@
+    ASSERT_GT(N, OutputCMRs[I].LineStart);
+    EXPECT_EQ(FileNames[OutputCMRs[I].LineStart],
+              OutputFiles[OutputCMRs[I].FileID]);
----------------
ikudrin wrote:
> vsk wrote:
> > Is there a reason to prefer `OutputCMRs[I].LineStart` over `OutputCMRs[I].FileID` on this line?
> The same as above, the test shouldn't rely on any specific sorting order of regions.
I see.


http://reviews.llvm.org/D18757





More information about the llvm-commits mailing list