[PATCH] D18822: [Polly][FIX] Adjust execution context of hoisted loads wrt. error domains

[Johannes Doerfert via llvm-commits]

On 04/07, Michael Kruse wrote:
> 2016-04-07 15:52 GMT+02:00 Tobias Grosser <tobias at grosser.es>:
> >> I don't know. I just noticed I (usually) do not use the __isl_* in the
> >> cpp if it is not static, however that doesn't seem to be the case often.
> >> If you prefer the second style we can use that one, but then I will
> >> immediately raise the same question for arguments in the definition.
> >> Do we want:
> >>    ScopArrayInfo::getFromAccessFunction(__isl_keep isl_pw_multi_aff *PMA)
> >> {
> >>      ...
> >>    }
> >> or
> >>    ScopArrayInfo::getFromAccessFunction(isl_pw_multi_aff *PMA) {
> >>      ...
> >>    }
> >
> >
> > I would go for the first. The same reasoning applies and it is also more
> > consistent.
> >
> > If we agree on this, I propose to add the annotations at places where they
> > are missing. (Obviously, this is not coupled to this patch. Just a note for
> > myself).
> 
> Just some remark:
> If in the long run we could switch to a C++ wrapper of isl, such
> annotation wouldn't be necessary anymore.
That was a topic 2 years ago,... I would not hold my breath ;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160407/a78df9c6/attachment.sig>