[PATCH] D18706: [DWARF] Force a linkage_name on an inlined subprogram's abstract origin

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 14:58:00 PDT 2016


On Wed, Apr 6, 2016 at 9:15 AM, Paul Robinson via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> probinson added a comment.
>
> In http://reviews.llvm.org/D18706#393310, @dblaikie wrote:
>
> > Seems this makes the flag (dwarf-linkage-names=*) a bit erroneous, no?
>
>
> That's true, it doesn't completely disable linkage names any more. Make
> that a 3-way flag?  -dwarf-linkage-names={All,Abstract,None}.  The more
> complicated decision-making can be buried inside useLinkageNames() which
> would now take a bool saying whether the DIE is abstract.
>

Would strike me as a bit odd - if "none" is not needed by anyone, we
probably shouldn't leave it around.


>
> > Would it be better to trigger this directly off the debugger tuning flag
>
> >  now & drop the specific named flag?
>
>
> No.  The original discussion over "tuning" specifically concluded that
> tuning should expand to defaults for feature-specific flags, and never be a
> controlling condition on its own.  It should always be possible to override
> a tuning with specific flags.
>

Yeah, I don't quite recall the specifics of the conversation/that
conclusion.


>
>
> http://reviews.llvm.org/D18706
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160406/4a711ced/attachment.html>


More information about the llvm-commits mailing list