[PATCH] D18712: [LoopUnroll] Fix the way we update DT after complete unrolling.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 14:00:03 PDT 2016


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with a minor nit inline


================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:564
@@ +563,3 @@
+          continue;
+        BasicBlock *PrevIDom = ChildDomNode->getIDom()->getBlock();
+        BasicBlock *NewIDom =
----------------
Isn't `PrevIDom` the same as `BB`?


http://reviews.llvm.org/D18712





More information about the llvm-commits mailing list