[PATCH] D17864: [PGO] Promote indirect calls to conditional direct calls with value-profile

[Rong Xu via llvm-commits]

xur marked 2 inline comments as done.
xur added a comment.

I will check Attribute::OptimizeNone per @joker.eph's suggestion.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:229
@@ -227,1 +228,3 @@
+  // Indirect call promotion.
+  MPM.add(createPGOIndirectCallPromotionPass());
 }
----------------
johanengelen wrote:
> Placing add(createPGOIndirectCallPromotionPass()) here means that IndirectCallPromotionPass will be enabled at -O0, which I think is undesirable.
Good point. We should not do this in O0. I'll move this call out of this function.

================
Comment at: lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:558
@@ +557,3 @@
+    }
+  }
+
----------------
joker.eph wrote:
> Why isn't is a function pass?
mainly I need to create InstrProfSymtab which is module level. I don't want to create this symtab for each function.


http://reviews.llvm.org/D17864