[PATCH] D18830: [llvm] GVN.cpp: Do not swap when both LHS and RHS are arguments.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 10:24:15 PDT 2016


I don't believe this case is testable, because line 1904 should swap them
back into the right order anyway.
All this patch will do is avoid extra work.


On Wed, Apr 6, 2016 at 9:50 AM, Aditya Kumar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> hiraditya added a comment.
>
> In http://reviews.llvm.org/D18830#393321, @joker.eph wrote:
>
> > Test?
>
>
> I came across this when I was reading the code, as such I do not know how
> to come up with a test case for this specific case.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18830
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160406/b2250819/attachment.html>


More information about the llvm-commits mailing list