[PATCH] D18706: [DWARF] Force a linkage_name on an inlined subprogram's abstract origin

[Paul Robinson via llvm-commits]

probinson added a comment.

In http://reviews.llvm.org/D18706#393310, @dblaikie wrote:

> Seems this makes the flag (dwarf-linkage-names=*) a bit erroneous, no?


That's true, it doesn't completely disable linkage names any more. Make that a 3-way flag?  -dwarf-linkage-names={All,Abstract,None}.  The more complicated decision-making can be buried inside useLinkageNames() which would now take a bool saying whether the DIE is abstract.

> Would it be better to trigger this directly off the debugger tuning flag

>  now & drop the specific named flag?


No.  The original discussion over "tuning" specifically concluded that tuning should expand to defaults for feature-specific flags, and never be a controlling condition on its own.  It should always be possible to override a tuning with specific flags.


http://reviews.llvm.org/D18706