[PATCH] D18674: [ThinLTO/gold] Change preempted def to avail extern linkage when possible

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 13:25:20 PDT 2016


rafael added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:779
@@ +778,3 @@
+      // FIXME: For can preempted Comdat members be dropped from their
+      // Comdat so they can use available_externally linkage?
+      if (options::thinlto && !GV->hasComdat() &&
----------------
It is OK to have available_externally to a comdat member, no?

I mean, it is equivalent to a declaration, and we can have a declaration to a comdat member.


http://reviews.llvm.org/D18674





More information about the llvm-commits mailing list