[PATCH] D18778: [LLVM] Fix Clang-tidy modernize-deprecated-headers warnings in remaining files; other minor fixes

[Aaron Ballman via llvm-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM (with minor nit about header ordering).


================
Comment at: lib/Support/SHA1.cpp:50
@@ -48,2 +49,3 @@
 
-static uint32_t rol32(uint32_t number, uint8_t bits) {
+namespace {
+
----------------
Eugene.Zelenko wrote:
> aaron.ballman wrote:
> > I think that having a single static function definition is a bit more clear than having an anonymous namespace, but I don't feel that strongly about it. Thoughts?
> I definitely saw single functions in anonymous namespace in LLVM code.
I've seen it before, I'm just not convinced it's actually worth the extra few lines of code. Regardless, we prefer inline namespaces, so I say it's good enough.


Repository:
  rL LLVM

http://reviews.llvm.org/D18778