[PATCH] D18739: Don't omit dynamic relocations for the GOT.

[Ed Schouten via llvm-commits]

ed added a comment.

In http://reviews.llvm.org/D18739#391880, @rafael wrote:

> The code does look wrong. It happens to work given the current implementations of isRelRelative. You should completely delete Dynrel, if we need a relocation for the got entry itself should only depend on the symbol and whether the output is relocatable (Config->Pic).


Done! Does this look all right?

> Do you have a testcase for which it fails it currently fails? If so, please add a testcase. If not, this is still a nice cleanup


Yes! I've just written a test.


http://reviews.llvm.org/D18739