[PATCH] D18108: Swift Calling Convention: SelectionDAGBuilder changes to support swifterror

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Manman,

LGTM with one comment.

Cheers,
-Quentin


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5724
@@ +5723,3 @@
+      SwiftErrorVal = V;
+      // We find the virtual register for the actual swifterror argument.
+      // Instead of using the Value, we use the virtual register instead.
----------------
Could you add a test case for that change?


http://reviews.llvm.org/D18108