[PATCH] D18656: [SimplifyLibCalls] Strip dead code in printf() transformations

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 01:41:34 PDT 2016


Right.

Thank you,

  Filipe

On Tue, Apr 5, 2016 at 2:22 AM, Sanjay Patel <spatel at rotateright.com> wrote:
> spatel added a comment.
>
> In http://reviews.llvm.org/D18656#390825, @filcab wrote:
>
>> Do you want to add an assert somewhere?
>>  Just in case :-)
>
>
> I think we're already safe here. On failure (eg, putchar is not available), emitPutChar() returns nullptr, so optimizePrintFString() will also return nullptr to signal to its caller that the transform didn't work.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18656
>
>
>


More information about the llvm-commits mailing list