[llvm] r265376 - [Support] Fix an invalid character escaping in string literal (unittest).

Etienne Bergeron via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 18:46:26 PDT 2016


Author: etienneb
Date: Mon Apr  4 20:46:26 2016
New Revision: 265376

URL: http://llvm.org/viewvc/llvm-project?rev=265376&view=rev
Log:
[Support] Fix an invalid character escaping in string literal (unittest).

Summary:
A character within a string literal is not escaped correctly.
In this case, there is no semantic change because the invalid character turn out to be NUL anyway.

note: "\0x12" is equivalent to {0, 'x', '1', '2'} and not { 12 }.

This issue was found by clang-tidy.

Reviewers: rnk

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D18747

Modified:
    llvm/trunk/unittests/Support/Path.cpp

Modified: llvm/trunk/unittests/Support/Path.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/Path.cpp?rev=265376&r1=265375&r2=265376&view=diff
==============================================================================
--- llvm/trunk/unittests/Support/Path.cpp (original)
+++ llvm/trunk/unittests/Support/Path.cpp Mon Apr  4 20:46:26 2016
@@ -725,7 +725,7 @@ const char coff_bigobj[] = "\x00\x00\xff
 const char coff_import_library[] = "\x00\x00\xff\xff....";
 const char elf_relocatable[] = { 0x7f, 'E', 'L', 'F', 1, 2, 1, 0, 0,
                                  0,    0,   0,   0,   0, 0, 0, 0, 1 };
-const char macho_universal_binary[] = "\xca\xfe\xba\xbe...\0x00";
+const char macho_universal_binary[] = "\xca\xfe\xba\xbe...\x00";
 const char macho_object[] =
     "\xfe\xed\xfa\xce........\x00\x00\x00\x01............";
 const char macho_executable[] =




More information about the llvm-commits mailing list