[PATCH] D18719: setUsedInRegulawrObj and MustBeInDynSym fixes

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 17:47:26 PDT 2016


davide added a comment.

In http://reviews.llvm.org/D18719#391920, @pcc wrote:

> Obsoleted by http://reviews.llvm.org/D18780 and http://reviews.llvm.org/D18781.


Yes it is.


================
Comment at: ELF/SymbolTable.cpp:102-103
@@ -101,1 +101,4 @@
   Lto.reset(new BitcodeCompiler);
+  for (auto &F : ObjectFiles)
+    for (auto S : F->getSymbols())
+      S->repl().setUsedInRegularObj();
----------------
pcc wrote:
> ruiu wrote:
> > Please use real types instead of `auto`.
> This part is (I believe) redundant with Davide's r265208.
Yes it is.


http://reviews.llvm.org/D18719





More information about the llvm-commits mailing list