[PATCH] D18772: [lld] Implement --dynamic-list

[Peter Collingbourne via llvm-commits]

pcc added a subscriber: pcc.

================
Comment at: ELF/ScriptParser.cpp:23-25
@@ -21,1 +22,5 @@
 
+// Returns true if S matches T. S can contain glob meta-characters.
+// The asterisk ('*') matches zero or more characacters, and the question
+// mark ('?') matches one character.
+bool elf::matchGlobStr(StringRef S, StringRef T) {
----------------
ruiu wrote:
> zatrazz wrote:
> > ruiu wrote:
> > > At least for now, I don't want to support glob patterns at all. Glob pattern can have huge performance impact on the linking speed. In most cases users pass a list of complete symbol names, so we should reject any patterns that contains glob metacharacters and do simple hash table lookup instead of glob pattern matching.
> > As stated in http://llvm.org/pr26693 it is required for the sanitizers and at least from LLVm side it the main motivator for this patch. I think we can add an additional check on DynamicList to check if an dynamic list and fast return if it is not the case.
> Do you need the glob pattern fro the sanitizer?
FWIW, I think it should be pretty trivial to avoid using glob patterns in the sanitizer dynamic lists.


Repository:
  rL LLVM

http://reviews.llvm.org/D18772