[PATCH] D18731: ELF: Create dynamic symbols for symbol aliases of copy relocations.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 14:38:48 PDT 2016


On Mon, Apr 4, 2016 at 2:33 PM, Rafael EspĂ­ndola <rafael.espindola at gmail.com
> wrote:

> On 4 April 2016 at 17:29, Peter Collingbourne <peter at pcc.me.uk> wrote:
> > pcc added a comment.
> >
> >> Please check all relocations in the test.
> >
> >
> > I don't understand what you're asking for. There are two relocations,
> and I'm checking both of them (and that there are no others).
>
> True. I just noticed the CHECK-NOT.
>
> I think the canonical ways of doing it is
>
> // CHECK:      Relocations [
> // CHECK-NEXT:...
> ...
> // CHECK-NEXT: ]
>
> which makes it a bit easier to see that there are no other relocations.
>

Okay, I've updated the test to do it that way.


-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160404/84568018/attachment.html>


More information about the llvm-commits mailing list