[lld] r265293 - Don't store an Elf_Sym for most symbols.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 12:33:12 PDT 2016


>>    void wrap(StringRef Name);
>>    InputFile *findFile(SymbolBody *B);
>> +  void resolve(SymbolBody *Body);
>>
>>  private:
>>    Symbol *insert(SymbolBody *New);
>>    void addLazy(Lazy *New);
>>    void addMemberFile(Undefined *Undef, Lazy *L);
>> -  void resolve(SymbolBody *Body);
>
>
> Why did you change the visibility of resolve() function?

Sorry, I had that in an earlier version of the patch but it was not
needed in the final one. I reverted this bit in r265336.

BTW, I tested cleaning this up a bit by either always reading symbol
names early or late. Amusingly they are both slower. I will still work
a bit on the "always late" patch, but we might really be in a sweet
spot for when to read global/local names.

Cheers,
Rafael


More information about the llvm-commits mailing list