[PATCH] D18574: Replace MachineRegisterInfo::isSSA() with a MachineFunctionProperty
Derek Schuff via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 4 10:59:40 PDT 2016
dschuff added a comment.
Put the MRI accessor back, and kept all of its uses.
(But kept the new `MachineFunction::print()` behavior)
================
Comment at: include/llvm/CodeGen/MachineRegisterInfo.h:163
@@ -162,3 @@
- // register.
- bool isSSA() const { return IsSSA; }
-
----------------
qcolombet wrote:
> Can we keep the getter and setter, just update what they do?
We can; that would obviously make this change smaller, and be easier on out-of-tree targets. Longer term if/when we get more properties we might still want to make them nicer to use. But I'm fine with keeping this accessor; the compiled code would pretty much be identical anyway.
http://reviews.llvm.org/D18574
More information about the llvm-commits
mailing list