[PATCH] D18579: SetVector: Add front, pop_front and additional constructor.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 09:52:00 PDT 2016


That seems like a somewhat strange API - calling reserve down into the
vector (& possibly the set, for things like DenseSet) seems more
appropriate, no?

On Fri, Apr 1, 2016 at 5:05 PM, Matthias Braun via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> MatzeB retitled this revision from "SetVector: Add front, pop_front and
> resize operations" to "SetVector: Add front, pop_front and additional
> constructor.".
> MatzeB updated the summary for this revision.
> MatzeB updated this revision to Diff 52448.
> MatzeB added a comment.
>
> New version which does not introduce the resize() (or reserve()) operation
> anymore in favor of a constructor allowing to supply (empty) instances for
> the vector and set.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D18579
>
> Files:
>   include/llvm/ADT/SetVector.h
>   unittests/ADT/SetVectorTest.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160404/b2242c81/attachment.html>


More information about the llvm-commits mailing list