[PATCH] D18732: [SystemZ] Support LRVH and STRVH opcodes

[Ulrich Weigand via llvm-commits]

uweigand added a comment.

Your change to README.txt implies that LRVH and STRVH still are not generated by the compiler.  However, the change to SystemZInstrInfo.td actually installs DAG patterns for the SelectionDAG pass to recognize, so this is somewhat confusing.

Do those DAG patterns actually not match?  If so, it might be better to not provide any.  (Or of course even better, provide ones that actually work.)   Or do they in fact match, and you just didn't verify that?  If so, it would be good update README.txt accordingly and add a CodeGen test to verify correct code generation.

In any case, adding new instructions requires adding tests that they assemble and disassemble correctly, in test/MC/SystemZ/insn-*.s and test/MC/Disassembler/SystemZ/insns*.txt, respectively.


http://reviews.llvm.org/D18732