[polly] r265280 - [FIX] Do not create a SCoP in the presence of infinite loops

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 4 02:03:50 PDT 2016


On 04/04, Tobias Grosser wrote:
> On 04/04/2016 01:09 AM, Johannes Doerfert via llvm-commits wrote:
> >Author: jdoerfert
> >Date: Sun Apr  3 18:09:06 2016
> >New Revision: 265280
> >
> >URL: http://llvm.org/viewvc/llvm-project?rev=265280&view=rev
> >Log:
> >[FIX] Do not create a SCoP in the presence of infinite loops
> >
> >   If a loop has no exiting blocks the region covering we use during
> >   schedule genertion might not cover that loop properly. For now we bail
> >   out as we would not optimize these loops anyway.
> 
> Thanks for the quick fix. Out of interest: What was the issue that had to be
> resolved to make this work?
The changes in ScopInfo.cpp were left over from an earlier attempt to fix
this. I did a soft reset to keep the test cases and forgot to remove
that part. Since the test cases worked and the changes in the ScopDetection
should never cause any "problems" I committed it. Once I noticed my
mistake you already reverted it. (Thanks for that by the way.)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: Digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160404/3a1fec9c/attachment.sig>


More information about the llvm-commits mailing list